Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a11y issues in FileUploader #16564

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented May 23, 2024

Closes #16524

Fixed a11y issues with the FileUploader.
Now we are checking if there is an errorSubject and invalid prop to set an aria-describedby and we are filtering spaces on the name prop.

Testing / Reviewing

  • Check with the Accesibility Checker with invalid set to true.

Copy link

netlify bot commented May 23, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 62a1f3a
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/664fa53b625c9300087df7a0
😎 Deploy Preview https://deploy-preview-16564--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 23, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 62a1f3a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/664fa53b1a21840008c17500
😎 Deploy Preview https://deploy-preview-16564--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones tay1orjones added this pull request to the merge queue Jun 13, 2024
Merged via the queue into carbon-design-system:main with commit 1d72445 Jun 13, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: FileUploaderItem creates invalid 'aria-describedby' property
3 participants