fix(16575): modify useIsTruncated hook in ListBoxMenuItem #16576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Gururajj77
approved these changes
May 27, 2024
2nikhiltom
approved these changes
May 27, 2024
|
Awesome! Thanks for the fix! I'll keep the issue open because is was reported on the v10 branch, but I'll reference this PR if someone wants to backport the fix. |
guidari
approved these changes
May 28, 2024
2 tasks
alisonjoseph
approved these changes
May 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Jun 3, 2024
364ffc8
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #16575
When the dropdown item is selected, in the control in
useIsTruncatedhook,element.lastElementChild?.lastElementChildalways be the path of the checkmark svg. OffsetWidth of this path was undefined and scrollWidth was 0. Because of thatuseIsTruncatedreturns false and the tooltip was not working. I modified the inside of the hook. it always gets the offsetWidth and scrollWidth of the element so it works fine.Changelog
New
Changed
useIsTruncatedhook inListBoxMenuItemcomponent to always use the element's offsetWidth and scrollWidth, fixing the issue with the tooltip not displaying.Removed
useIsTruncatedhook that references the path of the checkmark svg.Testing / Reviewing
The full text of the dropdown item now appears in the tooltip on hover, whether the item is selected or not. You can see the issue before it was fixed in the issue closed by this commit.