Dropdown does not announce items in JAWS #16688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
approved these changes
Jun 6, 2024
tay1orjones
approved these changes
Jun 7, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jun 7, 2024
17a8721
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16260
After we added this code from this PR the Dropdown is not announcing the items when using JAWS. That is because we are declaring our own
idinstead of using the fromdownshift.I tested with their example on the website to see if declaring the
idthere would have the same result and it happens the same thing, the JAWS can't read the items. I opened an issue in the downshift github.We can either remove the
idthat we have as an example like it's done on this PR, or we can remove the code from the PR mentioned above. I would just remove theidsfor now.Testing / Reviewing