Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code-connect): connect Search, Select, RadioButton, RadioButtonGroup #16782

Merged

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Jun 13, 2024

Closes #16680
Closes #16682
Closes #16681

Changelog

New

  • connect Select, FluidSelect, RadioButton, RadioButtonGroup, SelectSkeleton, RadioButtonSkeleton, Search, FluidSearch, FluidSearchSkeleton

Changed

  • add fix for helperText to all components (only show message when toggle is true)

Testing / Reviewing

@alisonjoseph alisonjoseph requested a review from a team as a code owner June 13, 2024 18:39
Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit df8a9f6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/666b3cd5a739a70008ec0d26
😎 Deploy Preview https://deploy-preview-16782--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit df8a9f6
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/666b3cd5a541520008ff63f4
😎 Deploy Preview https://deploy-preview-16782--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 45f3a52
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66748b6c0e72b900083233ae
😎 Deploy Preview https://deploy-preview-16782--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 45f3a52
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66748b6c685e6a000894a02c
😎 Deploy Preview https://deploy-preview-16782--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph marked this pull request as draft June 14, 2024 16:18
@alisonjoseph alisonjoseph changed the title feat(code-connect): connect Select and FluidSelect feat(code-connect): connect Select, FluidSelect, RadioButton, RadioButtonGroup Jun 17, 2024
@alisonjoseph alisonjoseph marked this pull request as ready for review June 17, 2024 18:37
@alisonjoseph alisonjoseph marked this pull request as draft June 17, 2024 18:39
@alisonjoseph alisonjoseph changed the title feat(code-connect): connect Select, FluidSelect, RadioButton, RadioButtonGroup feat(code-connect): connect Search, Select, RadioButton, RadioButtonGroup Jun 17, 2024
@alisonjoseph alisonjoseph marked this pull request as ready for review June 17, 2024 20:47
@alisonjoseph alisonjoseph merged commit 5e000ea into carbon-design-system:main Jun 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Connect : Radio button Code Connect : Search Code Connect : Select
1 participant