-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(search): a11y warning on search not expanded #16873
fix(search): a11y warning on search not expanded #16873
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
5c37cc7
Hey there! v11.61.0 was just released that references this issue/PR. |
Closes carbon-design-system/ibm-products#4766
IBM Equal Access Accessibility Checker - warning on the search icon with
role="button"
since it's not tabbableChangelog
Changed
aria-label
androle
for the search icon to only have values whenonExpand
Testing / Reviewing
Ran the IBM Equal Access Accessibility checker on the component
Before:
After: