Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 16446 fix calendar icon css issue #17127

Closed

Conversation

NabeelAyubee
Copy link
Contributor

@NabeelAyubee NabeelAyubee commented Aug 8, 2024

Closes #16446

Calendar icon CSS issue fix when inline props is true
DatePicker story added with inline props true

Changelog

Changed

  • Changed flatpickr calendar position to absolute and inset block start to auto

Testing / Reviewing

  • Tested in storybook when inline props is set to true. calendar icon is showing correctly

@NabeelAyubee NabeelAyubee requested a review from a team as a code owner August 8, 2024 19:44
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


nabeelmd-eGov seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot.

@NabeelAyubee NabeelAyubee changed the title fix: 14831 fix calendar icon css issue fix: 16466 fix calendar icon css issue Aug 8, 2024
@NabeelAyubee NabeelAyubee changed the title fix: 16466 fix calendar icon css issue fix: 16446 fix calendar icon css issue Aug 8, 2024
Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fe34327
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66b5203c67fef20008424ca7
😎 Deploy Preview https://deploy-preview-17127--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit fe34327
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66b5203cb6f4230008c609cc
😎 Deploy Preview https://deploy-preview-17127--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NabeelAyubee NabeelAyubee deleted the fix-14831 branch August 9, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Calendar icon in Datepicker input got displaced when providing the prop inline to true
1 participant