Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calendar): fix calendar icon CSS issue #16446 #17144

Merged
merged 6 commits into from
Aug 19, 2024

Conversation

NabeelAyubee
Copy link
Contributor

Closes #16446

-Calendar icon CSS issue fix when inline props is true
-DatePicker story added with inline props true

Changelog

New

-Added story for DatePicker with inline true in storybook

Changed

  • Changed flatpickr calendar position to absolute and inset block start to auto

Testing / Reviewing

Testing / Reviewing

  • Tested in storybook when inline props is set to true. calendar icon is showing correctly

@NabeelAyubee NabeelAyubee requested a review from a team as a code owner August 12, 2024 15:22
@NabeelAyubee
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 423e6d5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66c3979f1a61f50009842752
😎 Deploy Preview https://deploy-preview-17144--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 423e6d5
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66c3979f3fd2840008f4ff1b
😎 Deploy Preview https://deploy-preview-17144--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's remove the inline story before merging as this is not a documented variant of the DatePicker

@NabeelAyubee
Copy link
Contributor Author

LGTM, let's remove the inline story before merging as this is not a documented variant of the DatePicker

Thanks for the suggestion. I have removed the DatePicker inline story as mentioned

@NabeelAyubee
Copy link
Contributor Author

NabeelAyubee commented Aug 19, 2024

@guidari Can you please review the PR ? I've got one approval.

@guidari guidari enabled auto-merge August 19, 2024 19:15
@guidari guidari added this pull request to the merge queue Aug 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2024
@guidari guidari added this pull request to the merge queue Aug 19, 2024
Merged via the queue into carbon-design-system:main with commit e72ab12 Aug 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Calendar icon in Datepicker input got displaced when providing the prop inline to true
3 participants