Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aspect-ratio): correct example preview #17171

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Aug 14, 2024

Closes #17093

Surfaced in slack, there were some issues with the aspect ratio examples in the grid elements preview.

Changelog

Changed

  • include necessary styles
  • update markup to be correct

Testing / Reviewing

  • View the grid elements preview, the aspect ratio examples should render correctly and match the same we see in the react storybook (though the color styling is different and expected)
  • To do this locally, cd into this preview folder and run yarn && yarn develop

Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit ef15d13
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66ce114e1309100008e46a12
😎 Deploy Preview https://deploy-preview-17171--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ef15d13
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66ce114e3b0a82000816addb
😎 Deploy Preview https://deploy-preview-17171--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones
Copy link
Member Author

@kennylam @guidari Hey this is ready for review

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and the boxes are different now.
🚀

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@tay1orjones tay1orjones added this pull request to the merge queue Aug 28, 2024
Merged via the queue into carbon-design-system:main with commit e99eca3 Aug 28, 2024
23 checks passed
@tay1orjones tay1orjones deleted the 17093-aspect-ratio-example branch August 28, 2024 15:00
@carbon-automation
Copy link
Contributor

Hey there! v11.65.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Aspect ratio not working on grid preview site
3 participants