Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ai-label): add typescript types #17261

Closed
wants to merge 1 commit into from
Closed

feat(ai-label): add typescript types #17261

wants to merge 1 commit into from

Conversation

ariellalgilmore
Copy link
Member

Closes #17232

Add typescript types to AI-label

Changelog

Changed

  • Converted AILabel file from JS to TSX.
  • updated align to copy Popover syntax with deprecated values

Testing / Reviewing

functionality stay the same
checks still passing
storybook looks good

@netlify Netlify
Copy link

netlify bot commented Aug 23, 2024

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e775810
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66c8c7793332ac000828fe30
😎 Deploy Preview https://deploy-preview-17261--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Aug 23, 2024

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit e775810
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66c8c77a116122000877c809
😎 Deploy Preview https://deploy-preview-17261--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review August 23, 2024 18:25
@ariellalgilmore ariellalgilmore requested review from a team as code owners August 23, 2024 18:25
emyarod
emyarod approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ariellalgilmore
Copy link
Member Author

closing in favor for: #17295

@ariellalgilmore ariellalgilmore deleted the feat/typescript-ai-label branch October 10, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones is a code owner automatically assigned from carbon-design-system/release

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to AI Label (formerly Slug)
2 participants
@ariellalgilmore @emyarod