Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactivetag): added aria label for screen reader users #17282

Merged
merged 13 commits into from
Sep 11, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Aug 27, 2024

Closes #17106

Added an aria-label so the user knows it is on the tag group.

Testing / Reviewing

  • Use screen reader to test

@guidari guidari requested a review from a team as a code owner August 27, 2024 19:51
Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e6d3c0d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e18f8d9a4e8900084c7bef
😎 Deploy Preview https://deploy-preview-17282--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit e6d3c0d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e18f8daa322500080f3beb
😎 Deploy Preview https://deploy-preview-17282--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@tay1orjones tay1orjones changed the title fix: added aria label for screen reader users fix(interactivetag): added aria label for screen reader users Sep 9, 2024
@tay1orjones
Copy link
Member

@guidari this one has a failing avt test

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024
@guidari guidari added this pull request to the merge queue Sep 11, 2024
Merged via the queue into carbon-design-system:main with commit 28032c3 Sep 11, 2024
23 checks passed
@guidari guidari deleted the 17106-region branch September 11, 2024 14:46
@carbon-automation
Copy link
Contributor

Hey there! v11.66.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: Interactive Tag All variants - Interactive Tags /its content not defined with in a Labeled Region
5 participants