fix: cannot clear initial combobox value in fully controlled component #17324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
preetibansalui
changed the title
tay1orjones
approved these changes
Sep 9, 2024
Gururajj77
approved these changes
Sep 10, 2024
2 tasks
riddhybansal
approved these changes
Sep 16, 2024
Merged
via the queue into
carbon-design-system:main
with commit Sep 16, 2024
d8e0045
23 checks passed
guidari
pushed a commit
to guidari/carbon
that referenced
this pull request
Sep 18, 2024
carbon-design-system#17324) * fix: initial state issue * fix: added test case * fix: test case * fix: test case * fix: ci checks fail * fix: merge conflict issue --------- Co-authored-by: Taylor Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16856
Fixed - not able to clear initial state in a fully controlled component
Changelog
Added a new state in stateReducer
Testing / Reviewing
It should call onChange in initial change as well when component is fully controlled.