Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tabs): replace hardcoded CSS prefix #17423

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Sep 11, 2024

related #16908 #17422

This PR replaces hardcoded CSS prefix in Tabs

Changelog

Changed

  • CSS prefix in handleClose

Testing / Reviewing

confirm that the component behavior on close remains unchanged

@emyarod emyarod requested a review from a team as a code owner September 11, 2024 18:39
@emyarod emyarod changed the title fix(Tabs): replace hardcoded CSS prefixgit ch fix(Tabs): replace hardcoded CSS prefix Sep 11, 2024
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 26699cb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e2ee048670d20008c8330f
😎 Deploy Preview https://deploy-preview-17423--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 26699cb
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e2ee0453764d000865ade8
😎 Deploy Preview https://deploy-preview-17423--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.82%. Comparing base (a6f1b23) to head (26699cb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17423   +/-   ##
=======================================
  Coverage   76.82%   76.82%           
=======================================
  Files         408      408           
  Lines       13966    13966           
  Branches     4336     4288   -48     
=======================================
  Hits        10730    10730           
- Misses       3062     3063    +1     
+ Partials      174      173    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tay1orjones tay1orjones added this pull request to the merge queue Sep 12, 2024
Merged via the queue into carbon-design-system:main with commit 1e45149 Sep 12, 2024
23 checks passed
@emyarod emyarod deleted the fix/Tabs-replace-hardcoded-css-selector branch September 13, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants