-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ActionableNotification
with closeOnEscape
prop
#17433
Fixed ActionableNotification
with closeOnEscape
prop
#17433
Conversation
Co-authored-by: tay1orjones <[email protected]> Co-authored-by: Taylor Jones <[email protected]>
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17433 +/- ##
==========================================
- Coverage 76.87% 76.85% -0.02%
==========================================
Files 408 408
Lines 13974 13975 +1
Branches 4340 4337 -3
==========================================
- Hits 10742 10740 -2
- Misses 3058 3061 +3
Partials 174 174 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
06844e9
…gn-system#17433) * chore(release): v11.66.0 (carbon-design-system#17413) Co-authored-by: tay1orjones <[email protected]> Co-authored-by: Taylor Jones <[email protected]> * fix: fixed onKeyDown --------- Co-authored-by: carbon-automation[bot] <103539138+carbon-automation[bot]@users.noreply.github.com> Co-authored-by: tay1orjones <[email protected]> Co-authored-by: Taylor Jones <[email protected]> Co-authored-by: kennylam <[email protected]>
Closes #16153
The
addEventListener
keydown was being created even after removed. So now we are checking if theref.current
contains a value or it is null.Testing / Reviewing