Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(17398): fix Datepicker issue with Keyboard Navigation in Firefox #17435

Merged

Conversation

2nikhiltom
Copy link
Contributor

Closes #17398

This fixes the keyboard (Tab) navigation order in FireFox

Changelog

added event.preventDefault();

Testing / Reviewing

open deploy preview in FireFox
Open DatePicker - "range with Calendar" storybook example
Select the dates using keyboard after selection of end date press tab and verify that the focus moves to the next focusable element in the DOM
Also verify in other browser

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 34db335
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e3461ae4a8a10007efe51f
😎 Deploy Preview https://deploy-preview-17435--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 34db335
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e3461ae653c80008f5371b
😎 Deploy Preview https://deploy-preview-17435--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.82%. Comparing base (fdb31d9) to head (34db335).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ges/react/src/components/DatePicker/DatePicker.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17435      +/-   ##
==========================================
- Coverage   76.82%   76.82%   -0.01%     
==========================================
  Files         408      408              
  Lines       13973    13974       +1     
  Branches     4341     4289      -52     
==========================================
  Hits        10735    10735              
- Misses       3064     3066       +2     
+ Partials      174      173       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me on all browsers!

@kennylam kennylam added this pull request to the merge queue Sep 13, 2024
Merged via the queue into carbon-design-system:main with commit 47ceaad Sep 13, 2024
36 checks passed
guidari pushed a commit to guidari/carbon that referenced this pull request Sep 18, 2024
@guidari
Copy link
Contributor

guidari commented Oct 15, 2024

Hey @2nikhiltom looks like the focus still blocked in the last element on Firefox

https://deploy-preview-17435--v11-carbon-react.netlify.app/?path=/story/components-datepicker--range-with-calendar

I'm not sure if the issue closed is different or the same as this one: #17663

@2nikhiltom
Copy link
Contributor Author

Hi @guidari ! The issues are similar, we verified that the fix on this PR worked before merging. Seems like something has recently changed in firefox/flatpicker . could we track this via - issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Datepicker issue with Keyboard Navigation in Firefox
5 participants