fix: refactor and fix controlled combobox #17527
Merged
+196
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor code related to controlled combobox for simplicity. * Update ComboBox when selectedItem prop changes externally. * Call onChange when combobox is cleared or updated. * Unit tests for these cases. * Storybook example for fully controlled component.
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17527 +/- ##
=======================================
Coverage 77.03% 77.03%
=======================================
Files 408 408
Lines 13993 13995 +2
Branches 4321 4321
=======================================
+ Hits 10779 10781 +2
Misses 3041 3041
Partials 173 173 ☔ View full report in Codecov by Sentry. |
Gururajj77
approved these changes
Sep 30, 2024
preetibansalui
approved these changes
Oct 7, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 7, 2024
f232cb6
35 of 36 checks passed
|
Hey there! v11.68.0 was just released that references this issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16565
Refactor and bug fixes for controlled combobox
Changelog
Changed