Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(web-components): add missed storybook import extensions #17656

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

abdonrd
Copy link
Contributor

@abdonrd abdonrd commented Oct 4, 2024

The plain ESM standard imports should have extensions.

@abdonrd abdonrd requested a review from a team as a code owner October 4, 2024 18:04
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 07a54ad
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67002e3f3a49300008b4dbd6
😎 Deploy Preview https://deploy-preview-17656--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 07a54ad
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67002e3faec2e2000857a8f1
😎 Deploy Preview https://deploy-preview-17656--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.07%. Comparing base (e8c7672) to head (07a54ad).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17656   +/-   ##
=======================================
  Coverage   77.07%   77.07%           
=======================================
  Files         409      409           
  Lines       14021    14021           
  Branches     4355     4327   -28     
=======================================
  Hits        10807    10807           
  Misses       3043     3043           
  Partials      171      171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annawen1 annawen1 added this pull request to the merge queue Oct 8, 2024
Merged via the queue into carbon-design-system:main with commit df9ec56 Oct 8, 2024
36 checks passed
@abdonrd abdonrd deleted the patch-2 branch October 8, 2024 15:28
@carbon-automation
Copy link
Contributor

Hey there! v11.68.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants