Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit Test] - Selectable Tag #17711

Merged
merged 20 commits into from
Oct 16, 2024
Merged

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Oct 10, 2024

Closes #17437

Added test to Selectable Tag.
We can't cover 100% because of this topic: https://ibm-studios.slack.com/archives/C03430J3DBP/p1726857596307079
And we also are gonna remove slug in this PR, so we don't have to cover that

Testing / Reviewing

  • Test should be at 80.95%

@guidari guidari requested a review from a team as a code owner October 10, 2024 12:13
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6040ad5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6707c50951f9680008c60e28
😎 Deploy Preview https://deploy-preview-17711--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6040ad5
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6707c509402c3800089f6776
😎 Deploy Preview https://deploy-preview-17711--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 54cda2c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6707c5ffce5fa50008c8aa4e
😎 Deploy Preview https://deploy-preview-17711--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 459f81e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/670e979132460a0008b0af86
😎 Deploy Preview https://deploy-preview-17711--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 459f81e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/670e9791b61cc80008299725
😎 Deploy Preview https://deploy-preview-17711--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.44%. Comparing base (756834c) to head (459f81e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17711      +/-   ##
==========================================
+ Coverage   79.33%   79.44%   +0.11%     
==========================================
  Files         406      406              
  Lines       14019    14019              
  Branches     4388     4384       -4     
==========================================
+ Hits        11122    11138      +16     
+ Misses       2731     2715      -16     
  Partials      166      166              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annawen1 annawen1 added this pull request to the merge queue Oct 16, 2024
Merged via the queue into carbon-design-system:main with commit cb0764c Oct 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test coverage for SelectableTag
3 participants