fix(toggle): allow screen readers to announce labels #2819
Conversation
|
Deploy preview for the-carbon-components ready! Built with commit 57f1a9c https://deploy-preview-2819--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 57f1a9c https://deploy-preview-2819--carbon-components-react.netlify.com |
|
@carmacleod had requested letting screen reader not read on/off text, in #1794. Wanted to see if it's still the case. |
|
it seems we have conflicting feedback again, would be great if we can clear up the confusion and determine how to proceed |
|
@asudoh looks like #1794 is asking for modifying the aria attribute based on toggle state. do we want to keep our vanilla toggles usable without JS or should I implement this behavior? |
|
Please don't put this in yet, or change it based on state. I'm adding a comment to #2809 to explain. |
emyarod
force-pushed
the
2809-voiceover-does-not-announce-toggle-labels
branch
from
2f62f6a
to
e8d2c35
Compare
emyarod
force-pushed
the
2809-voiceover-does-not-announce-toggle-labels
branch
from
e8d2c35
to
061a2c9
Compare
|
superseded by #2885 |
Closes #2809
This PR removes the
aria-hiddenattributes from the toggle components to allow screen readers to announce toggle labels