fix(Tag): ignore click events when disabled #4792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 60b4537 https://deploy-preview-4792--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 60b4537 |
|
Deploy preview for carbon-components-react ready! Built with commit 60b4537 https://deploy-preview-4792--carbon-components-react.netlify.com |
joshblack
approved these changes
Dec 2, 2019
emyarod
force-pushed
the
4791-filter-tag-onclick-firing-when-disabled
branch
from
3d29bf3
to
38c846d
Compare
aledavila
approved these changes
Dec 3, 2019
joshblack
approved these changes
Dec 5, 2019
joshblack
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
laurenmrice
approved these changes
Dec 6, 2019
|
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
stale
bot
added
the
status: inactive
asudoh
removed
the
status: inactive
emyarod
force-pushed
the
4791-filter-tag-onclick-firing-when-disabled
branch
2 times, most recently
from
6bf731b
to
d633147
Compare
joshblack
suggested changes
Jan 7, 2020
emyarod
force-pushed
the
4791-filter-tag-onclick-firing-when-disabled
branch
from
5e88749
to
b24f6c8
Compare
|
@joshblack is this good to go now? |
emyarod
force-pushed
the
4791-filter-tag-onclick-firing-when-disabled
branch
from
9b25878
to
371ee11
Compare
joshblack
approved these changes
Jan 10, 2020
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
Jan 13, 2020
* fix(Tag): ignore click events when disabled * test(Tag): remove warning * fix(tag): move aria-label to button * fix: add ellipses when width is constrained * docs: fix example markup * fix(tag): reintroduce padding due to recent markup change * fix(Tag): remove unneeded click handler logic * fix(tag): use disabled token Co-authored-by: Josh Black <[email protected]>
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
Jan 14, 2020
* fix(Tag): ignore click events when disabled * test(Tag): remove warning * fix(tag): move aria-label to button * fix: add ellipses when width is constrained * docs: fix example markup * fix(tag): reintroduce padding due to recent markup change * fix(Tag): remove unneeded click handler logic * fix(tag): use disabled token Co-authored-by: Josh Black <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4791
This PR wraps the close icon in a buttonto utilize native button features (rather than spoofing a button with the SVG element) and ignores the onClick handler when the filter tag is disabledChangelog
New
Changed
wrap SVG icon in buttondue to changes introduced in fix(Tag): adds various fixes for screen reader accessibility; adds AAT #4863 the entire tag is now abuttonand the styles are rescoped to the svg icon within thebutton.bx--tagelementTesting / Reviewing
Ensure click handlers are no longer fired when the tag filter is disabled and the component matches the visual spec (particularly the disabled state)