Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): replace old spacing variables with new ones #4889

Merged
merged 4 commits into from
Dec 16, 2019
Merged

fix(styles): replace old spacing variables with new ones #4889

merged 4 commits into from
Dec 16, 2019

Conversation

jendowns
Copy link
Contributor

@jendowns jendowns commented Dec 16, 2019

I noticed there were a couple places where the old spacing variables were being used, so I replaced them with the new ones 👍

Based on the migration guide here: https://github.com/carbon-design-system/carbon/blob/master/docs/migration/10.x-layout.md#migrating

old variable new variable
$spacing-3xs $carbon--spacing-01, $spacing-01
$spacing-2xs $carbon--spacing-02, $spacing-02
$spacing-xs $carbon--spacing-03, $spacing-03
$spacing-sm $carbon--spacing-04, $spacing-04
$spacing-md $carbon--spacing-05, $spacing-05
$spacing-lg $carbon--spacing-06, $spacing-06
$spacing-xl $carbon--spacing-07, $spacing-07
$spacing-2xl $carbon--spacing-08, $spacing-08
$spacing-3xl $carbon--spacing-09, $spacing-09

Changelog

Changed

  • replace old spacing variables with new syntax

@jendowns jendowns requested a review from a team as a code owner December 16, 2019 17:50
@ghost ghost requested review from dakahn and joshblack December 16, 2019 17:50
@netlify
Copy link

netlify bot commented Dec 16, 2019

Deploy preview for carbon-components-react failed.

Built with commit c9fa760

https://app.netlify.com/sites/carbon-components-react/deploys/5df8077dde690b00092d2353

@netlify
Copy link

netlify bot commented Dec 16, 2019

Deploy preview for the-carbon-components ready!

Built with commit c9fa760

https://deploy-preview-4889--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Dec 16, 2019

Deploy preview for carbon-elements ready!

Built with commit c9fa760

https://deploy-preview-4889--carbon-elements.netlify.com

@joshblack joshblack requested a review from a team December 16, 2019 18:54
@ghost ghost requested review from jillianhowarth and removed request for a team December 16, 2019 18:54
@joshblack
Copy link
Contributor

joshblack commented Dec 16, 2019

Note to design review, these are the components that had their spacing tokens updated. Visually they should be the same unless the token used in the past was a mistake 👍

  • Accordion
  • Code Snippet
  • Copy Button
  • Data Table Action
  • Pagination

@asudoh asudoh merged commit 7e0f9c7 into carbon-design-system:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants