fix(multiselect): close button for tags #4890
Conversation
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 6c8c0e0 https://deploy-preview-4890--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 6c8c0e0 |
|
Deploy preview for carbon-components-react failed. Built with commit 6c8c0e0 https://app.netlify.com/sites/carbon-components-react/deploys/5df7d9042f473a000aa603ca |
|
Deploy preview for the-carbon-components ready! Built with commit 56d6ad8 https://deploy-preview-4890--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 56d6ad8 |
|
Deploy preview for carbon-components-react failed. Built with commit cd87efb https://app.netlify.com/sites/carbon-components-react/deploys/5df7db782136c50008218298 |
|
Deploy preview for carbon-components-react failed. Built with commit 56d6ad8 https://app.netlify.com/sites/carbon-components-react/deploys/5df9029de3d7760007066db0 |
|
Could someone check this on IE11? Every time i've seen it's to address positioning there but I don't have a windows VM anymore to check. |
|
@abbeyhrt just checked and it seems fine. There's an issue with the arrow on multiselect but it shouldn't be connected as this is styling for svg of tag.
|
|
For design reviewers, it seems like our MultiSelect had a visual regression when making a selection (the X icon was misaligned). This PR should address it in all browsers. |
|
Thank you for checking! @aledavila |
* fix(multiselect): close button for tags * chore: remove relative positioning
* fix(multiselect): close button for tags * chore: remove relative positioning
Closes #4888
Close svg for tags was not aligned.
Changelog
Removed
Testing / Reviewing
Make sure tag filter and multi select tags are working and close button is positioned correctly.