Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(pagination): update knob description for forwardText prop #4910

Merged
merged 2 commits into from
Dec 17, 2019
Merged

docs(pagination): update knob description for forwardText prop #4910

merged 2 commits into from
Dec 17, 2019

Conversation

jendowns
Copy link
Contributor

Changelog

Changed

  • updates knob description for forwardText prop

@jendowns jendowns requested a review from a team as a code owner December 17, 2019 22:25
@ghost ghost requested review from abbeyhrt and joshblack December 17, 2019 22:26
asudoh
asudoh approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @jendowns!

@netlify
Copy link

netlify bot commented Dec 17, 2019

Deploy preview for the-carbon-components ready!

Built with commit ad78ec2

https://deploy-preview-4910--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Dec 17, 2019

Deploy preview for carbon-components-react ready!

Built with commit ad78ec2

https://deploy-preview-4910--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Dec 17, 2019

Deploy preview for carbon-elements failed.

Built with commit ad78ec2

https://app.netlify.com/sites/carbon-elements/deploys/5df955f554ab6900085472c8

@asudoh asudoh merged commit 0d6f869 into carbon-design-system:master Dec 17, 2019
@netlify
Copy link

netlify bot commented Dec 17, 2019

Deploy preview for the-carbon-components ready!

Built with commit 72c6870

https://deploy-preview-4910--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Dec 17, 2019

Deploy preview for carbon-elements ready!

Built with commit 72c6870

https://deploy-preview-4910--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Dec 17, 2019

Deploy preview for carbon-components-react failed.

Built with commit 72c6870

https://app.netlify.com/sites/carbon-components-react/deploys/5df9572f0bcb170007aa5cf4

joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 6, 2020
@jendowns @joshblack
docs(pagination): update knob description for forwardText prop (carbo…
91d9381 
…n-design-system#4910)
@joshblack joshblack mentioned this pull request Jan 6, 2020
Closed
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

@joshblack joshblack joshblack approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jendowns @asudoh @joshblack @abbeyhrt