Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tile-group): remove unrecognized prop from tests #5026

Merged
merged 1 commit into from
Jan 13, 2020
Merged

chore(tile-group): remove unrecognized prop from tests #5026

merged 1 commit into from
Jan 13, 2020

Conversation

jendowns
Copy link
Contributor

The following error is generated in tests for TileGroup --

  ● Console

    console.error node_modules/react-dom/cjs/react-dom.development.js:545
      Warning: React does not recognize the `labelText` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attri
bute, spell it as lowercase `labeltext` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
          in input (created by RadioTile)
          in RadioTile (created by TileGroup)
          in div (created by TileGroup)
          in fieldset (created by TileGroup)
          in TileGroup (created by WrapperComponent)
          in WrapperComponent

It doesn't look like labelText is a valid prop for the component anymore.

Changelog

Removed

  • remove unrecognized labelText prop from TileGroup tests

@jendowns jendowns requested a review from a team as a code owner January 13, 2020 22:48
@ghost ghost requested review from abbeyhrt and joshblack January 13, 2020 22:48
@jendowns jendowns changed the title chore(tile-group): remove unrecognized props from tests chore(tile-group): remove unrecognized prop from tests Jan 13, 2020
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @jendowns!

@asudoh asudoh merged commit 462f956 into carbon-design-system:master Jan 13, 2020
@netlify
Copy link

netlify bot commented Jan 13, 2020

Deploy preview for the-carbon-components ready!

Built with commit b4e72ac

https://deploy-preview-5026--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 13, 2020

Deploy preview for carbon-elements ready!

Built with commit b4e72ac

https://deploy-preview-5026--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 13, 2020

Deploy preview for carbon-components-react failed.

Built with commit b4e72ac

https://app.netlify.com/sites/carbon-components-react/deploys/5e1cf3c568d1f70008bbf10e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants