Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tag): ensure tag keeps pill shape with single character #5053

Merged
merged 3 commits into from
Jan 15, 2020
Merged

fix(tag): ensure tag keeps pill shape with single character #5053

merged 3 commits into from
Jan 15, 2020

Conversation

tw15egan
Copy link
Member

Closes #5009

Adds in a min-width so that a single character in a tag still maintains a pill shape. Added justify-content: center to keep all items aligned in the center.

Changelog

New

  • min-width of 32px on all tags

Testing / Reviewing

Change a tag to a single digit and ensure the text is center-aligned and the tag is pill-shaped

@tw15egan tw15egan requested a review from a team as a code owner January 15, 2020 18:21
@netlify
Copy link

netlify bot commented Jan 15, 2020

Deploy preview for the-carbon-components ready!

Built with commit 9e5ee9f

https://deploy-preview-5053--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 15, 2020

Deploy preview for carbon-components-react ready!

Built with commit 9e5ee9f

https://deploy-preview-5053--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 15, 2020

Deploy preview for carbon-elements ready!

Built with commit 9e5ee9f

https://deploy-preview-5053--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 15, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit 07d48f7

https://deploy-preview-5053--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 15, 2020 •
edited
Loading

Deploy preview for carbon-elements failed.

Built with commit 07d48f7

https://app.netlify.com/sites/carbon-elements/deploys/5e1f7047514b1f00085e7862

@netlify
Copy link

netlify bot commented Jan 15, 2020 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit 07d48f7

https://app.netlify.com/sites/carbon-components-react/deploys/5e1f7047a0553600078e3db9

aagonzales
aagonzales approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 looks perfect!

asudoh
asudoh approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @tw15egan!

@asudoh asudoh merged commit e49944d into carbon-design-system:master Jan 15, 2020
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 23, 2020
@tw15egan @joshblack
fix(tag): ensure tag keeps pill shape with single character (carbon-d…
7246188 
…esign-system#5053)
@joshblack joshblack mentioned this pull request Jan 23, 2020
Closed
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
@tw15egan tw15egan deleted the tag-single-digit branch April 28, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

@aagonzales aagonzales aagonzales approved these changes

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag component doesn't look like a tag when there is only one character
3 participants
@tw15egan @asudoh @aagonzales