fix(list): left align numbers #5100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
asudoh
requested review from
a team and
laurenmrice
and removed request for
a team
|
Deploy preview for the-carbon-components ready! Built with commit 15a18cb https://deploy-preview-5100--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 15a18cb |
|
Deploy preview for carbon-components-react ready! Built with commit 15a18cb https://deploy-preview-5100--carbon-components-react.netlify.com |
|
Vanilla looks good, the react link failed, but once that is up again i can review |
laurenmrice
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5097
Left aligns numbers instead of right aligning them. Since custom formatting is difficult with the auto-generated decimals, we can create pseudo decimals by combining
counter-incrementandcontentChangelog
New
Changed
Testing / Reviewing
bx--list__item, right click, copy > copy elementbx--list--orderedthen paste the element as many times as you'd like