Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tag): add default cursor to non-filter tag #5140

Merged
merged 8 commits into from
Jan 22, 2020
Merged

fix(tag): add default cursor to non-filter tag #5140

merged 8 commits into from
Jan 22, 2020

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Jan 22, 2020

Closes #5133

Adding the button reset caused all tag variants to get a pointer cursor. This specifys a default cursor for non-filter tags. 🏄

Changelog

New

  • adds cursor: default; to _tag.scss

Testing / Reviewing

  • Check the default tag and see no cursor change on hover
  • Check the filter tag and see a pointer cursor on hover

@dakahn dakahn requested a review from a team as a code owner January 22, 2020 19:44
@ghost ghost requested review from abbeyhrt and asudoh January 22, 2020 19:44
@dakahn dakahn requested review from joshblack and removed request for asudoh January 22, 2020 19:44
joshblack
joshblack reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dakahn should we make it so that the default tag has the old markup (span) and the filter tag has the button included?

@dakahn
Copy link
Contributor Author

dakahn commented Jan 22, 2020

I thought about that. Good suggestion. Will change. 👍

@netlify
Copy link

netlify bot commented Jan 22, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit 67d4c12

https://deploy-preview-5140--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 22, 2020

Deploy preview for carbon-elements ready!

Built with commit 5f5ee87

https://deploy-preview-5140--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 22, 2020

Deploy preview for carbon-components-react ready!

Built with commit 5f5ee87

https://deploy-preview-5140--carbon-components-react.netlify.com

abbeyhrt
abbeyhrt approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dakahn dakahn requested a review from joshblack January 22, 2020 20:06
@netlify
Copy link

netlify bot commented Jan 22, 2020 •
edited
Loading

Deploy preview for carbon-elements failed.

Built with commit 67d4c12

https://app.netlify.com/sites/carbon-elements/deploys/5e28c4234026ff0008b2e005

@netlify
Copy link

netlify bot commented Jan 22, 2020 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit 67d4c12

https://app.netlify.com/sites/carbon-components-react/deploys/5e28c4237eea0c0008874141

@asudoh asudoh merged commit a04a3d5 into carbon-design-system:master Jan 22, 2020
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 23, 2020
@dakahn @joshblack
fix(tag): add default cursor to non-filter tag (carbon-design-system#…
0fbfae9 
…5140)
@joshblack joshblack mentioned this pull request Jan 23, 2020
Closed
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
component: tags status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default tag now includes button styles
6 participants
@dakahn @joshblack @tw15egan @abbeyhrt @asudoh @vpicone