fix(button): set min-height for field buttons #5176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit beaf56c https://deploy-preview-5176--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit beaf56c |
|
Deploy preview for carbon-components-react ready! Built with commit beaf56c https://deploy-preview-5176--carbon-components-react.netlify.com |
emyarod
force-pushed
the
5164-field-button-min-height
branch
from
a41c237
to
810b544
Compare
aledavila
approved these changes
Jan 27, 2020
|
since the netlify previews are not building, adding a screenshot to show how field buttons will grow if there is text overflow
|
laurenmrice
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5164
This PR removes the fixed height on field buttons to allow them to grow vertically
Changelog
Changed
Removed
heightTesting / Reviewing
check field button height when text content overflows