Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change order import of tag css #5182

Merged
merged 5 commits into from
Jan 28, 2020
Merged

Change order import of tag css #5182

merged 5 commits into from
Jan 28, 2020

Conversation

xxxle0
Copy link
Contributor

@xxxle0 xxxle0 commented Jan 25, 2020 •
edited
Loading

Closes issue

We need change import css order because button-reset override type-style

Testing / Reviewing

after change:
Screen Shot 2020-01-25 at 4 36 55 PM

@xxxle0 xxxle0 requested a review from a team as a code owner January 25, 2020 09:36
@ghost ghost requested review from abbeyhrt and tw15egan January 25, 2020 09:36
@netlify
Copy link

netlify bot commented Jan 25, 2020

Deploy preview for the-carbon-components ready!

Built with commit 3b9a39a

https://deploy-preview-5182--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 25, 2020

Deploy preview for carbon-components-react ready!

Built with commit 3b9a39a

https://deploy-preview-5182--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 25, 2020

Deploy preview for carbon-elements ready!

Built with commit 3b9a39a

https://deploy-preview-5182--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 25, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit 95d6105

https://deploy-preview-5182--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 25, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 95d6105

https://deploy-preview-5182--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 25, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 95d6105

https://deploy-preview-5182--carbon-components-react.netlify.com

@asudoh asudoh requested review from a team and aagonzales and removed request for a team January 26, 2020 00:28
@asudoh
Copy link
Contributor

asudoh commented Jan 26, 2020

@carbon-design-system/design Could you please review to see tag is not broken in UX perspective? Thanks!

asudoh
asudoh approved these changes Jan 26, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍 - Thanks @xxxle0 for jumping in!

aagonzales
aagonzales approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asudoh asudoh merged commit cf84bd0 into carbon-design-system:master Jan 28, 2020
@xxxle0 xxxle0 deleted the duytran/fix-import-order-tag branch January 28, 2020 00:52
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@xxxle0 xxxle0 mentioned this pull request Feb 4, 2020
Closed
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

@aagonzales aagonzales aagonzales approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carbon tag text size is not showing up correctly in prod
6 participants
@xxxle0 @asudoh @aagonzales @abbeyhrt @laurenmrice @tw15egan