fix(notification): update status icon description prop #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit f6f7d45 |
|
Deploy preview for carbon-components-react ready! Built with commit f6f7d45 https://deploy-preview-5266--carbon-components-react.netlify.com |
emyarod
approved these changes
Feb 10, 2020
tw15egan
force-pushed
the
notification-icon-update
branch
from
cd2940f
to
c093482
Compare
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5261
Adds in a new prop,
statusIconDescriptionthat allows a user to add a description to the status icon. Defaults to${kind} iconif no prop is provided.Changelog
New
statusIconDescriptionRemoved
NotificationIconno longer takes the sameiconDescriptionas the close buttonTesting / Reviewing
Ensure the status icon and close button have different text on hover, even if no description is provided.