Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change padding column to 1rem #5366

Conversation

xxxle0
Copy link
Contributor

@xxxle0 xxxle0 commented Feb 17, 2020

Closes #5360

change padding of data table

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

@xxxle0 xxxle0 requested a review from a team as a code owner February 17, 2020 13:55
@ghost ghost requested review from abbeyhrt and tw15egan February 17, 2020 13:55
@tw15egan
Copy link
Member

Small issue on first column of sortable data table

Screen Shot 2020-02-17 at 3 04 56 PM

@netlify
Copy link

netlify bot commented Feb 17, 2020

Deploy preview for carbon-elements ready!

Built with commit d23b190

https://deploy-preview-5366--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Feb 17, 2020

Deploy preview for carbon-components-react ready!

Built with commit d23b190

https://deploy-preview-5366--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Feb 17, 2020

Deploy preview for carbon-elements ready!

Built with commit 26efd6f

https://deploy-preview-5366--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Feb 17, 2020

Deploy preview for carbon-components-react ready!

Built with commit 26efd6f

https://deploy-preview-5366--carbon-components-react.netlify.com

@xxxle0 xxxle0 force-pushed the duytran/5360-padding-column-table-data branch from 43e135d to 81c1f43 Compare February 17, 2020 15:58
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks for fixing.

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @xxxle0 🎉

@joshblack
Copy link
Contributor

Note for whoever merges this in, I think we'll need to update the commit line to:

fix(data-table): update spacing tokens for column padding

@asudoh asudoh merged commit 91c5ab0 into carbon-design-system:master Feb 17, 2020
asudoh added a commit that referenced this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data table] Column header padding wrong
6 participants