fix(number-input): fix positioning when no label is present #5376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 6d1a459 |
|
Deploy preview for carbon-components-react ready! Built with commit 6d1a459 https://deploy-preview-5376--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 08f7d5b |
|
Deploy preview for carbon-components-react ready! Built with commit 08f7d5b https://deploy-preview-5376--carbon-components-react.netlify.com |
joshblack
approved these changes
Feb 19, 2020
aledavila
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5358
Fixes positioning issues when no label is present
Changelog
Changed
margin-topon helper text when the label is hiddenTesting / Reviewing
Remove label text, and check
hide label. Add text in whilehide labelis active and make sure the number input container does not move