fix(Copy): add aria-live to announce text updates #5386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
Deploy preview for carbon-elements ready! Built with commit e4fa42b |
|
Deploy preview for carbon-components-react ready! Built with commit e4fa42b https://deploy-preview-5386--carbon-components-react.netlify.com |
|
This looks great! I'm not sure why but for me it's announcing 'Copied' twice: |
|
for me inside storybook it does not repeat the text in the voiceover dialog, it just reads it twice
but this seems to be only in storybook, I can't reproduce it when viewing the component outside of storybook or even in the storybook canvas on a new tab |
abbeyhrt
approved these changes
Feb 19, 2020
emyarod
deleted the
5385-copy-button-announce-state-change-screenreader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5385
Closes #2523
This PR updates WAI-ARIA state so that changes in the
<CopyButton>are read by screen readersChangelog
New
aria-liveregionChanged
aria-labelbased on animation stateTesting / Reviewing
Interact with the copy button using a screen reader and observe if button label changes are immediately read