-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove duplicate scss-to-json dependency #5476
chore: remove duplicate scss-to-json dependency #5476
Conversation
cc @vpicone should this be listed in our dependencies? Don't know if I realized it was listed there with the update 🤔 |
Deploy preview for carbon-elements ready! Built with commit e7379af |
Deploy preview for carbon-components-react ready! Built with commit e7379af https://deploy-preview-5476--carbon-components-react.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit cfaa835 https://deploy-preview-5476--carbon-components-react.netlify.com |
Deploy preview for carbon-elements ready! Built with commit cfaa835 |
@joshblack @jendowns yeah it would appear I accidentally added it as a dependency rather than replacing the old devDependency. I actually don’t think we use this library anymore? We should either remove it all together or move it to be a devDep as it was before I failed miserably at updating it. |
@vpicone Right now, I have removed it from |
@jendowns I'd defer to @joshblack, but best I can tell we don't use this dependency anymore (I could be missing something). |
I mean I guess we can just remove both, do a |
Just pulled down and tested and seemed fine so I just removed it lol. If there is an issue we can add it back 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - Thanks @jendowns!
…esign-system#5476) * chore: remove duplicate scss-to-json dependency * chore(components): remove scss-to-json Co-authored-by: Josh Black <[email protected]>
I noticed the following error in the build output of
carbon-components
:It looks like
scss-to-json
is defined in two places:I removed the older version in the dependencies but please let me know if you have any concerns.
Changelog
Removed
scss-to-json
inpackage.json