Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate scss-to-json dependency #5476

Merged
merged 6 commits into from
Mar 2, 2020
Merged

chore: remove duplicate scss-to-json dependency #5476

merged 6 commits into from
Mar 2, 2020

Conversation

jendowns
Copy link
Contributor

I noticed the following error in the build output of carbon-components:

warning package.json: "dependencies" has dependency "scss-to-json"
with range "^2.0.0" that collides with a dependency in "devDependencies"
of the same name with version "1.1.0"

It looks like scss-to-json is defined in two places:

  1. Dependencies: https://github.com/carbon-design-system/carbon/blob/master/packages/components/package.json#L169
  2. Dev dependencies: https://github.com/carbon-design-system/carbon/blob/master/packages/components/package.json#L72

I removed the older version in the dependencies but please let me know if you have any concerns.

Changelog

Removed

  • remove duplicate older version of scss-to-json in package.json

@jendowns jendowns requested a review from a team as a code owner February 27, 2020 22:40
@ghost ghost requested review from asudoh and joshblack February 27, 2020 22:40
@joshblack
Copy link
Contributor

joshblack commented Feb 27, 2020

cc @vpicone should this be listed in our dependencies? Don't know if I realized it was listed there with the update 🤔

@netlify
Copy link

netlify bot commented Feb 27, 2020

Deploy preview for carbon-elements ready!

Built with commit e7379af

https://deploy-preview-5476--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Feb 27, 2020

Deploy preview for carbon-components-react ready!

Built with commit e7379af

https://deploy-preview-5476--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Feb 27, 2020

Deploy preview for carbon-components-react ready!

Built with commit cfaa835

https://deploy-preview-5476--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Feb 27, 2020

Deploy preview for carbon-elements ready!

Built with commit cfaa835

https://deploy-preview-5476--carbon-elements.netlify.com

@vpicone
Copy link
Contributor

vpicone commented Feb 27, 2020

@joshblack @jendowns yeah it would appear I accidentally added it as a dependency rather than replacing the old devDependency. I actually don’t think we use this library anymore? We should either remove it all together or move it to be a devDep as it was before I failed miserably at updating it.

@jendowns
Copy link
Contributor Author

@vpicone Right now, I have removed it from dependencies and kept the more updated version in devDependencies. But do you want me to remove it here?

@vpicone
Copy link
Contributor

vpicone commented Feb 28, 2020

@jendowns I'd defer to @joshblack, but best I can tell we don't use this dependency anymore (I could be missing something).

@tw15egan
Copy link
Member

I mean I guess we can just remove both, do a rm -rf .yarn-offline-mirror node_modules && yarn cache clean && yarn install and see if anything breaks with it removed?

@joshblack
Copy link
Contributor

Just pulled down and tested and seemed fine so I just removed it lol. If there is an issue we can add it back 👍

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @jendowns!

@joshblack joshblack merged commit 49a29c7 into carbon-design-system:master Mar 2, 2020
joshblack added a commit to joshblack/carbon that referenced this pull request Mar 10, 2020
…esign-system#5476)

* chore: remove duplicate scss-to-json dependency

* chore(components): remove scss-to-json

Co-authored-by: Josh Black <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants