Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): include build-info.json in files for svelte team #5536

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Mar 4, 2020

Closes #5501

This change will expose an internal file build-info.json to be consumed by the svelte team for their icons.

Changelog

New

Changed

  • Include build-info.json in files key of package.json

Removed

@joshblack joshblack requested a review from a team as a code owner March 4, 2020 23:59
@ghost ghost requested review from aledavila and emyarod March 5, 2020 00:00
@netlify
Copy link

netlify bot commented Mar 5, 2020

Deploy preview for carbon-components-react ready!

Built with commit 05086ae

https://deploy-preview-5536--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Mar 5, 2020

Deploy preview for carbon-elements ready!

Built with commit 05086ae

https://deploy-preview-5536--carbon-elements.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @joshblack!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any plans to publish to @carbon/icon-build-helpers to npm?
3 participants