fix(type): match scss definitions to js definitions #5625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 4c06596 |
|
Deploy preview for carbon-components-react ready! Built with commit 4c06596 https://deploy-preview-5625--carbon-components-react.netlify.com |
joshblack
approved these changes
Mar 13, 2020
dakahn
approved these changes
Mar 17, 2020
renmaddox
pushed a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…stem#5625) Co-authored-by: Josh Black <[email protected]>
renmaddox
added a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…esign-system#5625)" This reverts commit 7e734b1.
renmaddox
added a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…esign-system#5625)" This reverts commit 7e734b1.
renmaddox
pushed a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…stem#5625) Co-authored-by: Josh Black <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5548
Matches the
scssdefinitions to the source-of-truthjstype definitionsChangelog
Added
$expressive-heading-05should now getlightstyles at themdbreakpoint$expressive-heading-05and$expressive-heading-06line-height atmaxbreakpointTesting / Reviewing
Ensure nothing is broken, that the
scsstype definitions match thejsdefinitions