feat: pictograms-march-01 #5674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
description coming
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 0e91f93 |
|
Deploy preview for carbon-components-react ready! Built with commit 0e91f93 https://deploy-preview-5674--carbon-components-react.netlify.com |
|
These pictograms will need the dash naming structure. @emyarod do we need to do this now or can we do this after merging this pr. |
|
@laurenmrice would be great to get the dashes in now 👍 |
emyarod
reviewed
Mar 25, 2020
packages/pictograms/svg/3D chart.svg
Outdated
| @@ -0,0 +1,28 @@ | |||
| <?xml version="1.0" encoding="iso-8859-1"?> | |||
There was a problem hiding this comment.
I don't think we can have the file name begin with a number, it looks like that's what's causing the CI errors
|
I think it needs to happen in this PR @laurenmrice, also not sure if |
…pictograms-march-01
joshblack
approved these changes
Apr 2, 2020
laurenmrice
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
24 net new pictograms in Data Analytics category
updated categories.yml file
updated pictogram-master.ai file
note: did not add dashes to name, may have to be added
many more additions to come over the next few days in a separate pr
Changelog
New