fix(modal): ensure modal renders correctly on mobile safari #5776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
tw15egan
requested review from
a team and
laurenmrice
and removed request for
a team
emyarod
reviewed
Apr 1, 2020
There was a problem hiding this comment.
this resolves the issue (tested on mobile safari with a local build)
looks like the original position: relative is just carried over from 4dcd149. just wondering, instead of adding a specific media query could we make position: fixed; top: 0 the default behavior change the position back to its initial value at larger breakpoints?
|
@emyarod Yeah let's just do that instead |
|
Deploy preview for carbon-elements ready! Built with commit 6c2e01c |
|
Deploy preview for carbon-components-react ready! Built with commit 6c2e01c https://deploy-preview-5776--carbon-components-react.netlify.com |
emyarod
reviewed
Apr 2, 2020
emyarod
approved these changes
Apr 2, 2020
laurenmrice
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5755
Fixes a bug in regards to mobile Safari and the way they render the bottom menu bar (see link for more info). Uses browser-specific media query to fix the issue (MDN)
Changelog
New
Testing / Reviewing
Test out
Modalon an iPhone, or use the simulator via Xcode