fix(notification): fix low-contrast close button focus color #5793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-components-react ready! Built with commit bb6b890 https://deploy-preview-5793--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit bb6b890 |
laurenmrice
approved these changes
Apr 3, 2020
There was a problem hiding this comment.
I am going to approve this because this logic works correctly.
Eventually we do need to update our low contrast notifications in the dark themes, but for now it is still blocked by this issue: #4282
emyarod
approved these changes
Apr 3, 2020
aledavila
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5737
Adds normal focus styles to low-contrast
NotificationChangelog
New
Testing / Reviewing
Focus on the close button in low-contrast mode and ensure the focus indicator is visible