fix(data-table): fix table with overflow menu bugs

[tw15egan]

Closes #5792

Fixes an issue where negative margin was added to fix a react specific bug with overflow menu. Added in a more specific selector so it will only target the React implementation. Fixed a few other visual bugs when hovering over the overflow menu, see pics below:

Changelog

Changed

• Increased specificity with negative margin override so it only affects React implementation
• light overflow menu now uses the correct field-02 token
• Changed hover styles so that a) the overflow icon would not disappear when hovering over a menu item and b) there was not a small bar with an incorrect color showing

Testing / Reviewing

Test out any Data Table with an Overflow menu, and make sure positioning is correct. Also, check out styles when hovering over an overflow menu, and hover styles when the overflow menu is opened.

Worth checking out that the normal overflow menu is working as expected as well.

[netlify]

Deploy preview for carbon-elements ready!

Built with commit adefc93

https://deploy-preview-5794--carbon-elements.netlify.com

[netlify]

Deploy preview for carbon-components-react ready!

Built with commit adefc93

https://deploy-preview-5794--carbon-components-react.netlify.com

[asudoh]

LGTM 👍 - Thanks @tw15egan!

[designertyler]

Hey @tw15egan I'm still seeing that bar at the bottom of the overflow icon.

I think it's actually the drop shadow peeking up from behind. It's more obvious on the white and g10 themes.

[tw15egan]

@designertyler should be fixed now 👍

[aledavila]

lgtm

[designertyler]

I think it's looking better, but there's still a very very slight color shift happening. Taking the eyedropper to it shows that it's only a couple values away.

What could be causing it? Is it possible to fix?

[tw15egan]

@designertyler I'm guessing it is the drop shadow peeking out. If we increase the small pseudo ::after element that we are using to hide most of the drop shadow, it's going to look strange since it will be larger than the focus outline. Not sure this will be noticeable to anyone as-is

[designertyler]

This subtle color shift is an improvement to the current component, a better tradeoff and will be less noticeable than the focus issue that trying to solve it would cause.