Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add NPE check for single file drag and drop upload #5813

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Apr 6, 2020

Closes #5811

This PR prevents the drag and drop uploader examples from uploading undefined files when multiple is false

Testing / Reviewing

Ensure the storybook and code sandbox drag and drop uploaders examples function as expected

@emyarod emyarod requested a review from a team as a code owner April 6, 2020 17:14
@ghost ghost requested review from dakahn and joshblack April 6, 2020 17:14
@netlify
Copy link

netlify bot commented Apr 6, 2020

Deploy preview for carbon-elements ready!

Built with commit 76c00b2

https://deploy-preview-5813--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Apr 6, 2020

Deploy preview for carbon-components-react ready!

Built with commit 76c00b2

https://deploy-preview-5813--carbon-components-react.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @emyarod!

@asudoh
Copy link
Contributor

asudoh commented Apr 7, 2020

@emyarod thinks this is ready to merge - Thanks @emyarod!

@asudoh asudoh merged commit 0a8cc1c into carbon-design-system:master Apr 7, 2020
@emyarod emyarod deleted the 5811-single-file-upload-npe branch April 7, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DnD file other than predefined accept type throwing error
3 participants