-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(styles): add component token support for Sass Migration effort #8971
feat(styles): add component token support for Sass Migration effort #8971
Conversation
…at/add-component-token-support
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 7d27cb9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60d101602609930008f71421 😎 Browse the preview: https://deploy-preview-8971--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 7d27cb9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60d10160eff1200007739331 😎 Browse the preview: https://deploy-preview-8971--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
This PR updates the
theme
mixin to include component token maps which can be generated by aget-tokens
helper now available inutilities/component-tokens
. This should help unblock any efforts that use component tokens in our sass module refactor.More usage info for this approach can be found in: carbon-design-system/carbon-v11#1
Changelog
New
Changed
Removed