Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): add component token support for Sass Migration effort #8971

Merged

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Jun 21, 2021

This PR updates the theme mixin to include component token maps which can be generated by a get-tokens helper now available in utilities/component-tokens. This should help unblock any efforts that use component tokens in our sass module refactor.

More usage info for this approach can be found in: carbon-design-system/carbon-v11#1

Changelog

New

  • New utilities for working with component tokens, specifically a helper that lets you get the tokens from a token map for a specific theme

Changed

  • Update theme helper to take in a list of maps to allow component tokens to be passed in

Removed

@joshblack joshblack marked this pull request as ready for review June 21, 2021 16:41
@joshblack joshblack requested a review from a team as a code owner June 21, 2021 16:41
@netlify
Copy link

netlify bot commented Jun 21, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 7d27cb9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60d101602609930008f71421

😎 Browse the preview: https://deploy-preview-8971--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 21, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 7d27cb9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60d10160eff1200007739331

😎 Browse the preview: https://deploy-preview-8971--carbon-components-react.netlify.app

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@joshblack joshblack enabled auto-merge (squash) June 21, 2021 20:22
@joshblack joshblack changed the title Add component token support for Sass Migration effort feat(styles): add component token support for Sass Migration effort Jun 21, 2021
@joshblack joshblack merged commit 803662e into carbon-design-system:main Jun 21, 2021
@jnm2377 jnm2377 mentioned this pull request Jun 22, 2021
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants