Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): v10.38.0-rc.0 #8990

Merged
merged 5 commits into from
Jun 22, 2021
Merged

chore(release): v10.38.0-rc.0 #8990

merged 5 commits into from
Jun 22, 2021

Conversation

andreancardona
Copy link
Contributor

Release PR for v10.38.0-rc.0

@andreancardona andreancardona requested a review from a team as a code owner June 22, 2021 15:44
@andreancardona andreancardona requested review from tay1orjones, sstrubberg and jnm2377 and removed request for sstrubberg June 22, 2021 15:44
@netlify
Copy link

netlify bot commented Jun 22, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: dbb1850

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60d240d8834b260007423c56

😎 Browse the preview: https://deploy-preview-8990--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 22, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: dbb1850

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60d240d8595b3600076c5a51

😎 Browse the preview: https://deploy-preview-8990--carbon-components-react.netlify.app

jnm2377
jnm2377 approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once CI is passing

tay1orjones
tay1orjones reviewed Jun 22, 2021
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the yarn.lock should be updated with this

@jnm2377
Copy link
Contributor

jnm2377 commented Jun 22, 2021

@andreancardona did you run yarn?

@andreancardona
Copy link
Contributor Author

@andreancardona did you run yarn?

yep I did...looking into the issue now

@netlify
Copy link

netlify bot commented Jun 22, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: dbb1850

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60d240d87e66980008776032

😎 Browse the preview: https://deploy-preview-8990--carbon-react-next.netlify.app/iframe

@jnm2377
Copy link
Contributor

jnm2377 commented Jun 22, 2021

@tay1orjones I just updated the yarn lock

@andreancardona andreancardona enabled auto-merge (squash) June 22, 2021 19:58
@andreancardona andreancardona merged commit 2dfd835 into carbon-design-system:main Jun 22, 2021
@jnm2377 jnm2377 mentioned this pull request Jun 22, 2021
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@jnm2377 jnm2377 jnm2377 approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreancardona @jnm2377 @tay1orjones