Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): add default feature flag config #9939

Merged

Conversation

joshblack
Copy link
Contributor

Closes #9927

Update our usage of feature flags in the project. This also updates our storybook to correctly initialize feature flags.

Changelog

New

Changed

  • Add feature flag side effect import to storybook
  • Add default feature flag config for styles
  • Update feature-flag-enabled usage in notification to use feature-flags
  • Update toggle to use feature-flags namespace
  • Update Sass to latest version

Removed

Testing / Reviewing

  • Verify that the toggle story renders as expected in the carbon-react-next storybook
  • Verify tests pass as expected

@joshblack joshblack requested a review from a team as a code owner October 25, 2021 18:00
@netlify
Copy link

netlify bot commented Oct 25, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 8253cdd

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61783fdbc580e20008d13756

😎 Browse the preview: https://deploy-preview-9939--carbon-react-next.netlify.app/

@netlify
Copy link

netlify bot commented Oct 25, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 8253cdd

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61783fdbc876ac0007f75de3

😎 Browse the preview: https://deploy-preview-9939--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 25, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 8253cdd

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61783fdb98195700078b1690

😎 Browse the preview: https://deploy-preview-9939--carbon-components-react.netlify.app/

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notifications and Toggle look good in the next storybook 👍

Copy link
Member

@sstrubberg sstrubberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sstrubberg sstrubberg merged commit 4b34a8b into carbon-design-system:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The v11 feature flag is not enabled in the styles package
3 participants