Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Tearsheet): address Element type issue with portalTarget prop type #3621

Merged
merged 2 commits into from
Oct 17, 2023
Merged

fix(Tearsheet): address Element type issue with portalTarget prop type #3621

merged 2 commits into from
Oct 17, 2023

Conversation

matthewgallo
Copy link
Member

@matthewgallo matthewgallo commented Oct 17, 2023 •
edited
Loading

Contributes to #3620

Fixes issue with portalTarget prop type, instanceOf(Element) does not work with SSR apps because Element does not exist.

What did you change?

packages/ibm-products/src/components/Tearsheet/Tearsheet.js
packages/ibm-products/src/components/Tearsheet/TearsheetNarrow.js
packages/ibm-products/src/components/Tearsheet/TearsheetShell.js

How did you test and verify your work?

Storybook, confirmed there are no prop type errors

@matthewgallo matthewgallo requested a review from a team as a code owner October 17, 2023 14:05
@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited
Loading

✅ Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit db7f836
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/652e96fca5b8da000882fcf6
😎 Deploy Preview https://deploy-preview-3621--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewgallo matthewgallo added this pull request to the merge queue Oct 17, 2023
Merged via the queue into carbon-design-system:main with commit 81e07df Oct 17, 2023
13 checks passed
@matthewgallo matthewgallo deleted the 3620-fix-portal-target branch October 17, 2023 14:58
@matthewgallo matthewgallo mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elycheea elycheea elycheea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewgallo @elycheea