refactor: convert ToolbarButton to typescript #4440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
matthewgallo
added
component: Toolbar
version: 2
matthewgallo
approved these changes
Feb 27, 2024
Merged
via the queue into
carbon-design-system:main
with commit Feb 27, 2024
2ddf0a4
18 checks passed
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 23, 2024
#4437) * Boilerplate of a migration guide added. WIP * Wordsmithed a bit of the opening paragraph * WIP * WIP * Updated a few of the migrated components. * fix * refactor: convert ToolbarButton to typescript (#4440) * refactor: convert ToolbarButton to typescript * docs: update url * chore: format * fix: add repository config to community package json (#4444) * fix: add missing support for shouldDisableMenuItem (#4443) * fix(DataSpreadsheet): Reduce redundancy in handleKeyPress #4187 (#4217) * fix(DataSpreadsheet):refractor handleKeyPress method * fix(DataSpreadsheet):refractor handleKeyPress method update1 * fix(DataSpreadsheet):refractor handleKeyPress method lint * fix(DataSpreadsheet):refractor handleKeyPress method lint err * fix(DataSpreadsheet):refractor handleKeyPress method lint cahnges * feat: the button bar covers the last filter options for Datagrid filter panel #4337 (#4350) * Test commit, disregard * Fixing my trivial change * docs: continued progress on the migrated components section * docs: simple changes * docs: added carbon components that were forwarded * docs: added LOE column to roughly aid in estimating effort to migrate * docs: added reference urls * docs: updated comments * docs: working on loe column * docs: updated from paul's feedback * fix: updated searchbar components props based on pull 4923 * fix: updates from review --------- Co-authored-by: Paul Balchin <[email protected]> Co-authored-by: matassp <[email protected]> Co-authored-by: David Menendez <[email protected]> Co-authored-by: Matt Gallo <[email protected]> Co-authored-by: Amal K Joy <[email protected]> Co-authored-by: SeonyuK <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4276
Converts ToolbarButton component to use typescript, no visual component changes just refactoring.
Small PR to begin contributing with, I'll add more types if this goes well.
What did you change?
Converted
ToolbarButtoncomponent to typescript.Updated contribution docs to include an up to date link.
How did you test and verify your work?
Checked storybook and ran unit tests locally.