chore(search-bar): cleaned up props #4923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
davidmenendez
requested changes
Apr 22, 2024
3 tasks
|
@davidmenendez Sorry for the wait! I was busy fixing a problem we've had in Dotcom for a while. Let me know if there's anything else so we can get this merged! |
|
@IgnacioBecerra there are some failing |
…oducts into search-bar-prop-clean
davidmenendez
approved these changes
May 7, 2024
IgnacioBecerra
requested review from
annawen1 and
sangeethababu9223
and removed request for
a team
Merged
via the queue into
carbon-design-system:main
with commit May 13, 2024
a7c9c01
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4602
This PR cleans up the SearchBar props that were mentioned here. Groups up MultiSelect props for adopter ease of use.
What did you change?
placeHolderText->placeholderText(changed upper to lower caseh)How did you test and verify your work?
Changes work in my local Storybook instance