Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CoachmarkButton): convert to .tsx #5241

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented May 15, 2024

Closes #4495

This PR converts CoachmarkButton to TypeScript

What did you change?

  • file extension
  • TS interface

How did you test and verify your work?

storybook build and type checks

@emyarod emyarod requested a review from a team as a code owner May 15, 2024 19:24
@emyarod emyarod requested review from davidmenendez and matthewgallo and removed request for a team May 15, 2024 19:24
Copy link

netlify bot commented May 15, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 18ad95a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66450c02a72d990008ab0ecd
😎 Deploy Preview https://deploy-preview-5241--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewgallo matthewgallo added this pull request to the merge queue May 16, 2024
Merged via the queue into carbon-design-system:main with commit 6b33291 May 16, 2024
17 checks passed
@emyarod emyarod deleted the 4495-feat/coachmarkbutton-ts branch May 20, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Typescript types to CoachmarkButton
3 participants