Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch generics to using compound/simple member access terminology #1138

Merged
merged 3 commits into from
Mar 16, 2022
Merged

Switch generics to using compound/simple member access terminology #1138

merged 3 commits into from
Mar 16, 2022

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Mar 15, 2022 •
edited
Loading

This is following #1119 .

@josh11b josh11b requested review from a team as code owners March 15, 2022 22:59
zygoloid
zygoloid approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be useful to define something like a "qualified member access expression" as a compound member access expression where the member expression is a simple member access expression: a.(context.b). Talking about "compound member access syntax with a qualified member name" is a bit of a mouthful.

@josh11b josh11b merged commit 79462da into carbon-language:trunk Mar 16, 2022
@josh11b josh11b deleted the compound branch March 16, 2022 15:29
@josh11b
Copy link
Contributor Author

josh11b commented Mar 16, 2022

I think it might be useful to define something like a "qualified member access expression" as a compound member access expression where the member expression is a simple member access expression: a.(context.b). Talking about "compound member access syntax with a qualified member name" is a bit of a mouthful.

I'll address that in a follow up.

@josh11b josh11b mentioned this pull request Mar 17, 2022
Merged
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@josh11b
Switch generics to using compound/simple member access terminology (#…
f0d6e31 
…1138)

This is following #1119 .

* Updates terminology.md, overview.md, details.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid zygoloid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josh11b @zygoloid