Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ranged-based for for user-defined types #1885

Merged
merged 52 commits into from
Aug 25, 2023
Merged

ranged-based for for user-defined types #1885

Changes from 13 commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
c7b8ccf
Filling out template with PR 1885
Pixep Aug 3, 2022
a355466
Add context, other languages, and basic interfaces proposal
Pixep Aug 6, 2022
ef76d36
Cleanup proposal structure, add context and proposal details
Pixep Aug 6, 2022
83b208c
Fix various typos
Pixep Sep 24, 2022
217ee4e
docs: revert typo fix to generics, separate PR
Pixep Aug 13, 2022
02ee7f8
Drop 'Indexable' interface proposal
Pixep Oct 1, 2022
0471f8d
Add abstract section
Pixep Oct 1, 2022
cf71002
Fix invalid code flags, `()` for interfaces
Pixep Oct 1, 2022
91d9709
Add a basic cursor vs iterator paragraph
Pixep Oct 1, 2022
c90d7ba
Add `Get` method to `Iterator`
Pixep Oct 1, 2022
c9bbad7
Fix typos
Pixep Oct 2, 2022
0152f41
Drop 'TODO' section
Pixep Oct 3, 2022
00ef294
Park `Consumable` interface
Pixep Oct 3, 2022
bfcb08c
Add a list of use cases
Pixep Oct 13, 2022
4fe274f
Merge branch 'trunk' into proposal-for-statement
Pixep Oct 23, 2022
936bedc
p1885: add Iterator `Advance()` method
Pixep Oct 23, 2022
b435c6f
p1885: refer to `Advance` in for-loop logic
Pixep Nov 4, 2022
76f13e4
p1885: add mutable iterators
Pixep Nov 4, 2022
0d593e1
p1885: add support suggestions for main use cases
Pixep Nov 4, 2022
dd6e4b1
p1885: switch from `Optional(T)` to `T` for getters
Pixep Nov 4, 2022
48c95f7
p1885: fix interface name typo
Pixep Nov 4, 2022
bf7330b
Apply suggestions from code review
Pixep Nov 7, 2022
51aabf4
p1885: update from google docs
Pixep Jan 17, 2023
6f2dd82
p1885: drop outdated alternatives considered
Pixep Jan 17, 2023
40716c7
p1885: drop reference to future work from "Details"
Pixep Jan 22, 2023
c714989
p1885: fix superfluous line breaks
Pixep Jan 31, 2023
5c653a7
p1885: wording improvements and precisions from josh11b
Pixep Feb 1, 2023
c897aad
p1885: more changes
Pixep Feb 1, 2023
6d57ec8
p1885: more small changes
Pixep Feb 1, 2023
12e0ff9
p1885: clarified interface example
Pixep Feb 3, 2023
471a7af
p1885: expand on comments
Pixep Feb 3, 2023
3efeb38
p1885: add python `yield` example
Pixep Feb 3, 2023
0108dba
p1885: more updates
Pixep Feb 7, 2023
0c45a70
Fix code snippet typo
Pixep Mar 4, 2023
06bb190
Clarified C++ interoperability goals
Pixep Mar 6, 2023
c8d8bcf
Add carbon to cpp interop section
Pixep Mar 6, 2023
845e0aa
Fix iterator member typo
Pixep Mar 11, 2023
f90fbfd
Clarify sections for C++ interop
Pixep Mar 11, 2023
31f9361
Merge branch 'carbon-language:trunk' into proposal-for-statement
Pixep Apr 1, 2023
f5eea57
Add mitigation for container with large values
Pixep Apr 1, 2023
59637d2
Add Iterate to C++ interop sample implementation
Pixep Apr 2, 2023
63f927c
add copy constructor for cursor iterator
Pixep Apr 2, 2023
cc86c60
Update proposals/p1885.md
Pixep Apr 4, 2023
80a74cd
Improve C++ iterator sample
Pixep Apr 4, 2023
4fad5ef
Precise the impact of caching last value
Pixep Apr 4, 2023
ff102e4
Add suggestions from @josh11b
Pixep Apr 23, 2023
caa8d86
Add suggestion from @geoffromer
Pixep Apr 23, 2023
fe33c52
Fix typo on `Iterate` class name in c++ snippet
Pixep May 18, 2023
7b81a95
Clarified C++ requirements, and implementation example
Pixep May 18, 2023
0e545d8
Link range-based for statement from C++ standard.
Pixep May 22, 2023
8e1af85
Mention ranges consuming their input
Pixep May 22, 2023
4277d37
Force checks to re-run.
chandlerc Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading