Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pattern matching syntax and semantics #2188

Merged
merged 28 commits into from
Jan 7, 2023
Merged

Pattern matching syntax and semantics #2188

merged 28 commits into from
Jan 7, 2023

Commits on Sep 15, 2022

  1. Proposal: pattern matching syntax and semantics.

    @zygoloid
    zygoloid committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    f6e6558 View commit details
    Browse the repository at this point in the history

  2. Pre-commit.

    @zygoloid
    zygoloid committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    3040dcf View commit details
    Browse the repository at this point in the history

  3. Allow {.a: T, ...} as a pattern even though it contains no bindings.

    @zygoloid
    zygoloid committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    d2e03cb View commit details
    Browse the repository at this point in the history

  4. Avoid mismatched braces in examples.

    @zygoloid
    zygoloid committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    931068b View commit details
    Browse the repository at this point in the history

  5. Handle grouping parentheses.

    @zygoloid
    zygoloid committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    9551c27 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. Add bullets to prevent grammar productions from wrapping together 

    Co-authored-by: josh11b <[email protected]>
    @zygoloid @josh11b
    zygoloid and josh11b authored Sep 16, 2022
    Configuration menu
    Copy the full SHA
    0eb5834 View commit details
    Browse the repository at this point in the history

  2. Fix tuple / struct typo. 

    Co-authored-by: josh11b <[email protected]>
    @zygoloid @josh11b
    zygoloid and josh11b authored Sep 16, 2022
    Configuration menu
    Copy the full SHA
    e908623 View commit details
    Browse the repository at this point in the history

  3. Allow trailing comma for one-tuple patterns.

    @zygoloid
    zygoloid committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    7fee7d2 View commit details
    Browse the repository at this point in the history

  4. Allow reuse of comparison results. Improve wording. Add future work to 

    support dynamic type matching.
    @zygoloid
    zygoloid committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    1f3bb35 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Address review comments and feedback. Remove identifier: pattern.

    @zygoloid
    zygoloid committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    68de53b View commit details
    Browse the repository at this point in the history

  2. Add ref to carbon-language#157. 

    Co-authored-by: Geoff Romer <[email protected]>
    @zygoloid @geoffromer
    zygoloid and geoffromer authored Sep 20, 2022
    Configuration menu
    Copy the full SHA
    bbfccab View commit details
    Browse the repository at this point in the history

  3. Fix xref.

    @zygoloid
    zygoloid committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    db3de32 View commit details
    Browse the repository at this point in the history

  4. Add more xrefs to carbon-language#2022 and to carbon-language#1084.

    @zygoloid
    zygoloid committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    b12a666 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. Update proposals/p2188.md 

    Co-authored-by: Geoff Romer <[email protected]>
    @zygoloid @geoffromer
    zygoloid and geoffromer authored Sep 21, 2022
    Configuration menu
    Copy the full SHA
    d7a568d View commit details
    Browse the repository at this point in the history

  2. Update links now carbon-language#2022 has landed.

    @zygoloid
    zygoloid committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    591b77e View commit details
    Browse the repository at this point in the history

  3. Reformat

    @zygoloid
    zygoloid committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    b4d810b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'trunk' into proposal-pattern-match

    @zygoloid
    zygoloid committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    e6125b8 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Don't try to reason symbolically about types in templates.

    @zygoloid
    zygoloid committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    eabdce5 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Fix typo. 

    Co-authored-by: David Sankel <[email protected]>
    @zygoloid @camio
    zygoloid and camio authored Nov 1, 2022
    Configuration menu
    Copy the full SHA
    d968e0e View commit details
    Browse the repository at this point in the history

  2. Respond to some review comments.

    @zygoloid
    zygoloid committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    09fd308 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Add as-patterns as future work.

    @zygoloid
    zygoloid committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    c7ad276 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Require exhaustiveness as suggested in code review and discussed on 

    discord.

See
https://discord.com/channels/655572317891461132/748959784815951963/1037445448908161104
    @zygoloid
    zygoloid committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    f0cc392 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Add examples.

    @zygoloid
    zygoloid committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    213981b View commit details
    Browse the repository at this point in the history

  2. Re-add sharper template dependence rule.

    @zygoloid
    zygoloid committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    4f5b78e View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. Apply suggestions from code review 

    Co-authored-by: josh11b <[email protected]>
    @zygoloid @josh11b
    zygoloid and josh11b authored Dec 3, 2022
    Configuration menu
    Copy the full SHA
    85a1135 View commit details
    Browse the repository at this point in the history

  2. Review comments.

    @zygoloid
    zygoloid committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    a0803c0 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. Updates based on review comments.

    @zygoloid
    zygoloid committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    f832e40 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Add another benefit of is from the weekly sync meeting.

    @zygoloid
    zygoloid committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    acba0cd View commit details
    Browse the repository at this point in the history